-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utility CLI for DLite Entities Service #17
Draft
CasperWA
wants to merge
44
commits into
main
Choose a base branch
from
cwa/close-12-upload-script
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Map out the initial commands and (almost) finish upload and config.
Add testing dependencies (pytest). Add a special pylint run for tests and update workflows accordingly. Start the first test file for the `entities-service upload` CLI command. Also, fix filesuffix error for a workflow.
Prefer CLI-specific .env before a service-specific .env, and otherwise fallback to CONFIG defaults.
CasperWA
force-pushed
the
cwa/close-12-upload-script
branch
from
April 28, 2023 20:04
7ee2b2a
to
161c87e
Compare
These are currently only used in 'config show' to return the output in the given format, but are made as global options to be available whenever an output of that kind is desired.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
===========================================
- Coverage 75.00% 60.35% -14.65%
===========================================
Files 9 12 +3
Lines 200 502 +302
===========================================
+ Hits 150 303 +153
- Misses 50 199 +149
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There's an issue that the Option aliases are not being read.
It fails to parse the metadata of Option and Argument. Also, avoid using Python 3.10-style typing, since typer cannot handle it (X | Y). Indeed, to ensure pyupgrade doesn't change it automatically type aliases are created for all occurrences.
DLite does not support Python 3.12+.
3.11 introduces StrEnum.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12
Adds a utility CLI for use with DLite Entities Service.