-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip tests with missing requirements #1032
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is OK to skip tests locally due to missing of imports, but not on github. In this way we may risk to remove dependencies and thus stop testing parts of the code without it being picked up on in the CI/CD workflows.
If this is to be accepted, we need to have an additional check after ctest, that check that all skipped tests are in the specified list of tests (e.g. mongodb-test cannot run on github)
It can be implemented with importskip() checking an environment variable. If it is set, the skip will not be accepted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice.
Co-authored-by: Francesca L. Bleken <[email protected]>
Co-authored-by: Francesca L. Bleken <[email protected]>
Description
Skip tests with missing requirements
Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.