Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swig container #1020

Merged
merged 18 commits into from
Nov 28, 2024
Merged

Swig container #1020

merged 18 commits into from
Nov 28, 2024

Conversation

jesper-friis
Copy link
Collaborator

@jesper-friis jesper-friis commented Nov 27, 2024

Description

Combines PR #1017 and #1019.

Updated the weekly build of docker containers:

  • change to relative path in the COPY statements of the Dockerfiles generated with gen_dockerfile.sh
  • reduce number of build containers to 4: manylinux/musllinux, i686/x86_64
  • parametrised python versions
  • installed rust and cargo on musllinux and manylinux2014
  • updated ci_build_wheels to match the reduced number of containers that are build
  • install SWIG with pip instead of via the linux distribution to ensure a consistent swig version
  • avoid that split_url() and split_meta_uri() returns and extra None argument with SWIG 4.3.0

This PR should be followed up by a PR adding support for Python 3.13 and more included dependencies like pydantic, paramiko, pandas, ... (except for manylinux2014)

Type of change

  • Bug fix & code cleanup
  • New feature
  • Documentation update
  • Test update

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

@jesper-friis jesper-friis linked an issue Nov 27, 2024 that may be closed by this pull request
Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

I suggest writing an Issue on the needed follow-up PR.

@jesper-friis jesper-friis merged commit fae504a into master Nov 28, 2024
9 checks passed
@jesper-friis jesper-friis deleted the swig-container branch November 28, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for swig 4.3.0
2 participants