Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for removed emmo:hasDimension #1013

Merged
merged 7 commits into from
Dec 13, 2024
Merged

Workaround for removed emmo:hasDimension #1013

merged 7 commits into from
Dec 13, 2024

Conversation

jesper-friis
Copy link
Collaborator

@jesper-friis jesper-friis commented Nov 23, 2024

Description

hasDimension, Dimension and hasScalarData have been removed from EMMO. The two first will be readded after EMMO 1.0.0 has been released. The third must be discussed.

This PR provides a temporary workaround, keeping the old IRIs while waiting for hasDimension and Dimension to be readded and a decision for hasScalarData.

Type of change

  • Bug fix & code cleanup
  • New feature
  • Documentation update
  • Test update

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

@jesper-friis jesper-friis added the question Further information is requested label Nov 23, 2024
@francescalb
Copy link
Collaborator

Why was hasDimension removed from EMMO? If there is a rationale behind that should be reflected in the datadocumentation framework we should think a litlle bit more about this.

We could also check what the battery ontologies use. I think hasDimension is sued there (at least it was, so maybe they have changed it to something smart)

@jesper-friis jesper-friis changed the title Renamed emmo:hasDimention to oteio:hasDimension Workaround for emmo:hasDimension Dec 12, 2024
@jesper-friis jesper-friis removed the question Further information is requested label Dec 12, 2024
@jesper-friis
Copy link
Collaborator Author

jesper-friis commented Dec 12, 2024

Why was hasDimension removed from EMMO? If there is a rationale behind that should be reflected in the datadocumentation framework we should think a litlle bit more about this.

It needs a more rigorous conceptualisation.

We could also check what the battery ontologies use. I think hasDimension is sued there (at least it was, so maybe they have changed it to something smart)

To readd hasDimension we should create a full conceptualisation of fields. That will not be done before EMMO 1.0.0 has been released. We cannot wait for that, therefore this PR.

@jesper-friis jesper-friis changed the title Workaround for emmo:hasDimension Workaround for removed emmo:hasDimension Dec 13, 2024
@jesper-friis jesper-friis merged commit 1e5f50b into master Dec 13, 2024
9 checks passed
@jesper-friis jesper-friis deleted the hasDimension branch December 13, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants