Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore known but unimplemented sat systems when reading RINEX3 #24

Open
wants to merge 1 commit into
base: stable
Choose a base branch
from

Conversation

peci1
Copy link

@peci1 peci1 commented May 3, 2024

RINEX3 file https://igs.bkg.bund.de/root_ftp/IGS/BRDC/2024/124/BRDC00WRD_R_20241240000_01D_MN.rnx.gz contains Geosync satellite NAV messages which are not fully implemented in GNSSTk. When reading the data with RinexNavDataFactory, the reading immediately fails on the first Geosync satellite and makes it impossible to import the rest of the file.

This PR makes GNSSTk ignore these records instead of failing on them.


Reproducer:

gnsstk::NavLibrary lib;
gnsstk::NavDataFactoryPtr fac = std::make_shared<gnsstk::RinexNavDataFactory>();
fac->addDataSource(std::string(TEST_CACHE_DIR) + "BRDC00WRD_R_20241240000_01D_MN.rnx");
lib.addFactory(fac);
std::cout << gnsstk::printTime(gnsstk::CivilTime(lib.getInitialTime()), "%Y-%m-%d %H:%M:%f") << " --- "
          << gnsstk::printTime(gnsstk::CivilTime(lib.getFinalTime()), "%Y-%m-%d %H:%M:%f") << std::endl;

Output without this PR:

4713-1-1 0:0:0.000000 --- -4713-1-1 0:0:0.000000

Output with this PR:

2024-5-2 22:0:0.000000 --- 2024-5-4 0:25:0.000000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant