This repository has been archived by the owner on May 29, 2022. It is now read-only.
C++17 (replace throw with noexcept) #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JorgeFMorais
approved these changes
Apr 7, 2020
rconde01
reviewed
May 27, 2020
|
|
||
| /// Converts Rinex3NavData to a GPSEphemeris object. | ||
| operator GPSEphemeris() const throw(); | ||
| operator GPSEphemeris() const;// noexcept; |
There was a problem hiding this comment.
Suggested change
| operator GPSEphemeris() const;// noexcept; | |
| operator GPSEphemeris() const noexcept; |
rconde01
reviewed
May 27, 2020
|
|
||
| /// Converts this Rinex3NavData to a GloEphemeris object. | ||
| operator GloEphemeris() const throw(); | ||
| operator GloEphemeris() const;// noexcept; |
There was a problem hiding this comment.
Suggested change
| operator GloEphemeris() const;// noexcept; | |
| operator GloEphemeris() const noexcept; |
rconde01
reviewed
May 27, 2020
|
|
||
| /// Converts Rinex3NavData to a GalEphemeris object. | ||
| operator GalEphemeris() const throw(); | ||
| operator GalEphemeris() const;// noexcept; |
There was a problem hiding this comment.
Suggested change
| operator GalEphemeris() const;// noexcept; | |
| operator GalEphemeris() const noexcept; |
rconde01
reviewed
May 27, 2020
|
|
||
| /// Converts Rinex3NavData to a BDSEphemeris object. | ||
| operator BDSEphemeris() const throw(); | ||
| operator BDSEphemeris() const;// noexcept; |
There was a problem hiding this comment.
Suggested change
| operator BDSEphemeris() const;// noexcept; | |
| operator BDSEphemeris() const noexcept; |
rconde01
reviewed
May 27, 2020
|
|
||
| /// Converts Rinex3NavData to a QZSEphemeris object. | ||
| operator QZSEphemeris() const throw(); | ||
| operator QZSEphemeris() const;// noexcept; |
There was a problem hiding this comment.
Suggested change
| operator QZSEphemeris() const;// noexcept; | |
| operator QZSEphemeris() const noexcept; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only replace
throwwithnoexceptand can be compiled withset(CMAKE_CXX_STANDARD 17)in CMakeLists.txt.