Skip to content
This repository has been archived by the owner on May 29, 2022. It is now read-only.

Fixed incorrect accuracy assignment in Rinex3NavData from EphemerisGPS #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eugenyk
Copy link

@eugenyk eugenyk commented Sep 18, 2016

We suspect that in Rinex3NavData::operator GPSEphemeris should be
accuracy = gpseph.accuracy;

Because

  • gpseph.accuracy is never used during construction
  • GPSEphemeris::accuracyFlag is short but Rinex3NavData::accuracy is double
    And because of description
double accuracy;     ///< SV accuracy (m)
short accuracyFlag;        ///< Accuracy flag (URA)
double accuracy;           ///< Accuracy in meters (from accuracyFlag)

Unit test with conversion check added

@masamitsutech
Copy link
Contributor

Before this pull request can be reviewed for the next stable release, please update the branch to resolve possible merge conflicts.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants