Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMT sEEG electrodes #61

Merged
merged 5 commits into from
Dec 5, 2024
Merged

PMT sEEG electrodes #61

merged 5 commits into from
Dec 5, 2024

Conversation

Kinway25
Copy link
Collaborator

No description provided.

j-zimmermann
j-zimmermann requested changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@j-zimmermann j-zimmermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branch looks in principle good to merge.
However, please add according tests to the test suite.
The test file should be located in tests/electrode_tests

@j-zimmermann j-zimmermann merged commit 2d68102 into main Dec 5, 2024
9 checks passed
@j-zimmermann j-zimmermann deleted the PMT_sEEG branch December 5, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-zimmermann j-zimmermann j-zimmermann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kinway25 @j-zimmermann