Secure the Private Keys corresponding to SSL Certificates used by the HTTP daemon #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apache HTTP server according to the default locations: http://www.apache.com/how-to-setup-an-ssl-certificate-on-apache Add the correct TLS Private Keys file label for Debian systems. This patch fixes a serious Information Disclosure vulnerability caused by the erroneous labeling of TLS Private Keys and CSR, as explained above. See: SELinuxProject#735 Signed-off-by: Guido Trentalancia <[email protected]> --- policy/modules/system/miscfiles.fc | 3 +++ 1 file changed, 3 insertions(+)
This was referenced Nov 19, 2023
gtrentalancia
force-pushed
the
tls_privkey_fixes_pr
branch
from
98e7095 to
662502a
Compare
SSL Certificates used by the HTTP daemon. Signed-off-by: Guido Trentalancia <[email protected]> --- policy/modules/roles/webadm.te | 4 ++++ 1 file changed, 4 insertions(+)
and CSR used for example by the HTTP and/or Mail Transport daemons. Signed-off-by: Guido Trentalancia <[email protected]> --- policy/modules/services/certmonger.te | 3 +++ 1 file changed, 3 insertions(+)
gtrentalancia
force-pushed
the
tls_privkey_fixes_pr
branch
from
98e7095 to
2e27be3
Compare
pebenito
reviewed
Nov 28, 2023
pebenito
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Secure the Private Keys corresponding to SSL Certificates used by the HTTP daemon in order to fix a serious Information Disclosure vulnerability caused by the erroneous labeling of TLS Private Keys and CSR.
The new file contexts are based upon the official Apache HTTP Server recommended locations (see http://www.apache.com/how-to-setup-an-ssl-certificate-on-apache), have been extended to Debian and Gentoo locations, but might need to be further customized for other possible file locations which might still be exposed to the vulnerability.
RedHat distributions are not affected by this issue, thanks to cc91fed but apparentlly such change was not taken up by other distributions file contexts specifications.
Fixes: #735
Replaces: #733
Also fixes the certmonger module so that it can manage the above mentioned secret files.