Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System Tests #429

Merged
merged 1 commit into from
May 21, 2024
Merged

System Tests #429

merged 1 commit into from
May 21, 2024

Conversation

Angelyr
Copy link
Collaborator

@Angelyr Angelyr commented May 10, 2024

Added Github Action tests for Perlmutter and Frontier

@jacobmerson
Copy link
Contributor

Are the target endpoint ids supposed to be secret or those are fine to publish?

@Angelyr
Copy link
Collaborator Author

Angelyr commented May 12, 2024

@jacobmerson You need an authentication token to connect to the endpoint, so it is safe to publish the endpoint.

@cwsmith cwsmith changed the base branch from master to develop May 20, 2024 17:37
Copy link
Contributor

@cwsmith cwsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please rebase your branch on develop ?

@Angelyr Angelyr force-pushed the ac/system-actions branch from 27f5480 to da15a24 Compare May 21, 2024 19:59
@Angelyr
Copy link
Collaborator Author

Angelyr commented May 21, 2024

@cwsmith I have rebased the branch

Copy link
Contributor

@cwsmith cwsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@Angelyr
Copy link
Collaborator Author

Angelyr commented May 21, 2024

Cam you merge the branch for me?

@cwsmith cwsmith merged commit 90e1f46 into SCOREC:develop May 21, 2024
4 checks passed
@cwsmith cwsmith added the v2.2.9 label Oct 23, 2024
@cwsmith cwsmith mentioned this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants