Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy to prod #460

Merged
merged 61 commits into from
Apr 1, 2024
Merged

Deploy to prod #460

merged 61 commits into from
Apr 1, 2024

Conversation

epadams
Copy link
Contributor

@epadams epadams commented Apr 1, 2024

No description provided.

AaronKeys and others added 30 commits March 2, 2024 14:45
@AaronKeys
removed description duplicate
d85de02
@AaronKeys
small fixes for on enter, that got removed somehow
650497d
@AaronKeys
fixing the styling, so it's not as long.
ed4f869
@AaronKeys
added error detection, and code manipulation, but it's not catching t…
860c355 
…he null game
@AaronKeys
working on validation
26a9f28
@AaronKeys
error for title showing, but not for game. gives a game is null error.
028a30e
@AaronKeys
got passed the null click, but now the game isn't showing up red, as …
76c3981 
…an error.
@AaronKeys
not past the gamebox not showing red, but added limits on shortness a…
dbf6ca1 
…nd length
@AaronKeys
wrote a TODO comment for myself with hint at solution.
ef7565a
@AaronKeys
got the game and title errors displaying
436acc0
@AaronKeys
removed a lot of commented out code
15fc8d2
@AaronKeys
removed more comments.
9cc29b7
@AaronKeys
removed more comments
4edcdeb
@AaronKeys
ran npm run format and changed config back
409a48f
@AaronKeys
Merge branch 'main' into CreatePostCleanUp
aa56c8e
@AaronKeys
fixed problem with creating post and error that would still create post
f7a2c76
@AaronKeys
Merge branch 'CreatePostCleanUp' of https://github.com/SCCapstone/Pal…
9f5d24d 
…mettoProgrammers into CreatePostCleanUp
@AaronKeys
saving work after deleting a lot of code that almost, but didn't quit…
182b123 
…e work.
@AaronKeys
made it so if there were more than 3 characters, the warning text dis…
2ec9fa3 
…appears on title
@AaronKeys
fixed the value to short for game on the error message, but must fix …
cd774dc 
…in the other location now.
@AaronKeys
got several problems fixed with error.
1e30f74
@AaronKeys
removed unnessary commented out code.
225a967
@AaronKeys
config fix
4ff06a0
@AaronKeys
ran npm run format
ad44e1a
@AaronKeys
small changes
9bfae7e
@AaronKeys
lint format
c3263f6
@AaronKeys
changes to createpostcleanup
4bd3ec3
@AaronKeys
changing code to remove some errors, but there is at least one error …
5507506 
…left.
@AaronKeys
fixing two errors related to game usestate not being set to null.
df59402
@AaronKeys
create post cleanup seems to be working correctly.
1bb1e85
AaronKeys and others added 19 commits March 23, 2024 19:01
@AaronKeys
errors dont show initially
a28f9f2
@AaronKeys
disabled button
aeb4099
@AaronKeys
Delete FU.SPA/src/config.js
2f05074
@AaronKeys
Delete FU.SPA/src/components/Selectors.jsx
92e988f
@AaronKeys
trying to fix bug
6633766
@AaronKeys
merge
62e8c28
@AaronKeys
run format
56738dd
@AaronKeys
lint and format
f5ec819
@AaronKeys
npm run lint and format
2f7f7f4
@AaronKeys
changed config
63719aa
@AaronKeys
added starttime error and tried to check for it, but it doesn't appea…
9ab1660 
…r to be functioning at all.
@AaronKeys
small changes to starttime and error message
3192e1c
@epadams
Finished error checking for start end time, cleaned up state management
1b6cad7
@epadams
Cleaned up formatting and linting
38efd03
@epadams
Merge from main
7292dbe
@epadams
Remove config.js changes
147d023
@epadams
Merge pull request #358 from SCCapstone/CreatePostCleanUp
ac74eac 
Create post clean up
@epadams
hotfix
21a7478
@AaronKeys
Merge pull request #459 from SCCapstone/hotfix
bc510d3 
hotfix
@epadams epadams marked this pull request as draft April 1, 2024 00:58
@epadams epadams marked this pull request as ready for review April 1, 2024 00:58
AaronKeys
AaronKeys previously approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@AaronKeys AaronKeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@AaronKeys AaronKeys dismissed their stale review April 1, 2024 00:59

See a message saying this branch is out of date and want to check first

@epadams epadams marked this pull request as draft April 1, 2024 01:04
@epadams epadams marked this pull request as ready for review April 1, 2024 01:04
@epadams epadams merged commit fb73f77 into prod Apr 1, 2024
2 checks passed
@epadams epadams self-assigned this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronKeys AaronKeys AaronKeys approved these changes

@evan-scales evan-scales evan-scales approved these changes

Assignees

@epadams epadams

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@epadams @evan-scales @AaronKeys