Implement New Weaviate Repository #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiadams
reviewed
Aug 22, 2024
| @@ -123,17 +129,26 @@ async def get_all_concepts(): | |||
|
|
|||
|
|
|||
| @app.put("/concepts/{id}", tags=["concepts"]) | |||
| async def create_or_update_concept(id: str, terminology_id: str, name: str): | |||
There was a problem hiding this comment.
Unless the request param name matches the param name, this should not work afaik
Test for e.g./concepts/some_id
There was a problem hiding this comment.
You are right, I missed it. Fixed in the next push.
| @@ -143,33 +158,58 @@ async def get_all_mappings(): | |||
|
|
|||
|
|
|||
| @app.put("/concepts/{id}/mappings", tags=["concepts", "mappings"]) | |||
| async def create_concept_and_attach_mapping(id: str, terminology_id: str, concept_name: str, text: str): | |||
| async def create_concept_and_attach_mapping(concept_id: str, concept_name: str, terminology_name, text: str): | |||
| try: | |||
api/routes.py
Outdated
| raise HTTPException(status_code=404, detail=f"Concept with id {concept_id} not found") | ||
| result = repository.client.query.get( |
There was a problem hiding this comment.
this logic should be part of datastew imo
There was a problem hiding this comment.
You're right, we can have functions like get_terminology(terminology_name: str) and get_concept(concept_id: str). Should I start implementing it?
tiadams
requested changes
Aug 28, 2024
tiadams
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the new weaviate repository functions for the API endpoints.
closes #59