-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uart: set baudrate as configured in config file #32
Conversation
- GPS to UTC time correctly apply leap second offset - GGA only sent if a valid position is available - GGA is sent at 1 Hz only - Minor improvements Code is not yet tested nor build
Added RTCM subscriber and NMEA GGA publisher
Code cleanup
The use of rosidl_target_interfaces is deprecated (see [Humble release notes](http://docs.ros.org.ros.informatik.uni-freiburg.de/en/humble/Releases/Release-Humble-Hawksbill.html#deprecation-of-rosidl-target-interfaces). Here that actually causes an issue with CMake not setting the right include directory paths, breaking `colcon build` on humble. This applies the documented update, making the driver build under Humble (cherry picked from commit 84dd91a)
(cherry picked from commit 0872755)
(cherry picked from commit ab54c33)
@grischi When running your solution with an Ellipse D it doesn't work as expected. However, having a fixed list of baudrate in the code avoids being able to update it easily.
Moreover that would allow to extend with new possible values without having to build a new firmware. |
Hi @tolesam , I was able to reproduce the problem on our side and pushed a fix, so setting the baudrate shall now work. |
@grischi # Baud rate (4800 ,9600 ,19200 ,38400 ,115200 [default],230400 ,460800 ,921600)
baudRate: 115200
# Fallback baud rates to test if baudRate doesn't work
fallbackBaudRates:
- 115200
- 921600 |
replaced with #41 |
This PR extends the method for connecting to a serially connected sbg Ellipse D with unknown baudrate. If the baudrate from the .yaml config file does not work, one after the other possible baudrate is tried. Once a baudrate is found where connecting succeeds, it is used to set the baudrate from the .yaml config file on the device and re-connect.