Add bit macros from SA3 #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freshollie
reviewed
Nov 20, 2024
| @@ -37,8 +37,8 @@ | |||
| #define OAM_ENTRY_COUNT 128 | |||
| #if PORTABLE | |||
| // NOTE: Used in gba/types.h, so they have to be defined before the #include | |||
| #define DISPLAY_WIDTH 240 | |||
| #define DISPLAY_HEIGHT 160 | |||
| #define DISPLAY_WIDTH 426 | |||
There was a problem hiding this comment.
Are we doing widescreen by default now? ;)
freshollie
reviewed
Nov 20, 2024
| #define CheckBit(x, y) ((x) & (BitValue(y))) | ||
| #define GetBit(x, y) (((x) >> (y)) & 1) | ||
| #define SetBit(x, y) (x) |= BitValue(y) | ||
| #define SetSoleBit(x, y) (x) = BitValue(y) |
freshollie
reviewed
Nov 20, 2024
| @@ -786,7 +786,7 @@ static void Task_IntroColorAnimation(void) | |||
| } | |||
| } | |||
|
|
|||
| gUnknown_03002A80 = 2; | |||
| gUnknown_03002A80 = 2 * sizeof(int_vcount); | |||
There was a problem hiding this comment.
Unrelated change, but obviously makes sense to keep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.