Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue with set anchor method #3761

Draft
wants to merge 26 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
2d5cb7f
Fixes issue with set anchor method
walmazacn May 29, 2024
8f31d7d
Merge branch 'main' into 3399-set-anchor-for-wc-mf-in-modal
walmazacn May 31, 2024
562d076
Merge branch 'main' into 3399-set-anchor-for-wc-mf-in-modal
walmazacn Jun 4, 2024
50bd30d
Merge branch 'main' into 3399-set-anchor-for-wc-mf-in-modal
walmazacn Jun 4, 2024
0558fde
Merge branch 'main' into 3399-set-anchor-for-wc-mf-in-modal
walmazacn Jun 6, 2024
b4090b3
Fixes code review issue
walmazacn Jun 6, 2024
75db56b
Merge branch '3399-set-anchor-for-wc-mf-in-modal' of https://github.c…
walmazacn Jun 6, 2024
5aa4fbf
Fixes code review issues
walmazacn Jun 7, 2024
60567d5
Fixes minor issue
walmazacn Jun 7, 2024
7c6ffec
Merge branch 'main' into 3399-set-anchor-for-wc-mf-in-modal
walmazacn Jun 7, 2024
bc2ac37
Fixes code review issue
walmazacn Jun 7, 2024
ce23d31
Merge branch '3399-set-anchor-for-wc-mf-in-modal' of https://github.c…
walmazacn Jun 7, 2024
0a4765a
Merge branch 'main' into 3399-set-anchor-for-wc-mf-in-modal
walmazacn Jun 7, 2024
d469445
Merge branch 'main' into 3399-set-anchor-for-wc-mf-in-modal
walmazacn Jun 10, 2024
b15835c
Merge branch 'main' into 3399-set-anchor-for-wc-mf-in-modal
walmazacn Jun 13, 2024
e9a6361
Merge branch 'main' into 3399-set-anchor-for-wc-mf-in-modal
walmazacn Jun 19, 2024
f3cd9df
Merge branch 'main' into 3399-set-anchor-for-wc-mf-in-modal
walmazacn Jun 21, 2024
02f7235
Merge branch 'main' into 3399-set-anchor-for-wc-mf-in-modal
walmazacn Jul 2, 2024
0190ee6
Merge branch 'main' into 3399-set-anchor-for-wc-mf-in-modal
walmazacn Jul 16, 2024
7dcbc4b
Merge branch 'main' into 3399-set-anchor-for-wc-mf-in-modal
walmazacn Jul 17, 2024
a970aaa
Merge branch 'main' into 3399-set-anchor-for-wc-mf-in-modal
walmazacn Jul 29, 2024
38a6999
Merge branch 'main' into 3399-set-anchor-for-wc-mf-in-modal
walmazacn Aug 2, 2024
da76e5a
Merge branch 'main' into 3399-set-anchor-for-wc-mf-in-modal
walmazacn Aug 6, 2024
766d5fe
Merge branch 'main' into 3399-set-anchor-for-wc-mf-in-modal
walmazacn Aug 29, 2024
2648857
Merge branch 'main' into 3399-set-anchor-for-wc-mf-in-modal
walmazacn Sep 9, 2024
71680a4
Merge branch 'main' into 3399-set-anchor-for-wc-mf-in-modal
walmazacn Sep 13, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/src/App.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,9 @@
Iframe.removeInactiveIframes(node);
}
for (let i = mfModalList.length; i--; ) {
walmazacn marked this conversation as resolved.
Show resolved Hide resolved
if (mfModalList[i].modalWC && mfModalList[i].mfModal?.displayed) {
walmazacn marked this conversation as resolved.
Show resolved Hide resolved
continue;
}
closeModal(i);
}

Expand Down
4 changes: 1 addition & 3 deletions core/src/services/web-components.js
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,7 @@ class WebComponentSvcClass {
return wc.extendedContext.nodeParams;
},
setAnchor: anchor => {
if (!isSpecialMf) {
window.Luigi.routing().setAnchor(anchor);
}
window.Luigi.routing().setAnchor(anchor);
},
getAnchor: () => {
return window.Luigi.routing().getAnchor();
Expand Down