Skip to content

Commit

Permalink
add comments
Browse files Browse the repository at this point in the history
  • Loading branch information
cbarbian-sap committed Nov 28, 2024
1 parent b663b0b commit a725e65
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions pkg/reconciler/reconciler.go
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,10 @@ func (r *Reconciler) Apply(ctx context.Context, inventory *[]*InventoryItem, obj
// if item was not found, append an empty item
if item == nil {
// TODO: should the owner id check happen always (not only if the object is unknown to the inventory)?
// TODO: since deletion handling now happens late, it can happen that, when an object is moved from its previous compoment into a new one,
// and the previous one gets deleted at the same time, applying the new one runs stuck because of the owner id check;
// so we might add some logic to skip the owner id check in that particular case

// fetch object (if existing)
existingObject, err := r.readObject(ctx, object)
if err != nil {
Expand Down

0 comments on commit a725e65

Please sign in to comment.