Load skims into shared memory to be accessed by later models #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skims are loaded as a multiprocessing.shared_memory.SharedMemory buffer. Will only load skims from OMX if buffer does not already exist in shared memory. When used with an external script to hold onto shared memory, this allows skims to be kept in memory between models.
An additional improvement could be to add a GUID to the shared memory name as a failsafe to ensure the shared memory buffer is only usable by the current run. This GUID could potentially be set in network_los.yaml.
Functionality is currently disabled when running single-processed due to a crash that I am still investigating. This does mean that running a single-processed model after a multi-processed model will create two copies of the skims in memory, so ideally multiprocessing should be used either for all models or no models in a given run.