Vehicle Type Optimization #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhensle
requested changes
Mar 28, 2024
| @@ -347,6 +347,17 @@ def iterate_vehicle_type_choice( | |||
| model_settings, alts_cats_dict, vehicle_type_data | |||
| ) | |||
|
|
|||
| # alts preprocessor | |||
| alts_preprocessor_settings = model_settings.alts_preprocessor | |||
There was a problem hiding this comment.
This needs to be model_settings.get("alts_preprocessor", None)
| alts_preprocessor_settings = model_settings.alts_preprocessor | ||
| if alts_preprocessor_settings: | ||
| expressions.assign_columns( | ||
| state, |
There was a problem hiding this comment.
No state variable in this code base. This argument should be removed.
| @@ -380,6 +391,12 @@ def iterate_vehicle_type_choice( | |||
| len(choosers), | |||
| ) | |||
|
|
|||
| # filter columns of alts and choosers | |||
| if len(model_settings.get("COLS_TO_INCLUDE_IN_CHOOSER_TABLE")) > 0: | |||
There was a problem hiding this comment.
Need to set default for get function to be array. i.e. model_settings.get("COLS_TO_INCLUDE_IN_CHOOSER_TABLE", []). Here and below.
dhensle
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying a couple of the code changes from Pull Request #806 in the main repo to BayDAG_estimation to help with MemoryErrors occuring in the vehicle type choice model.