Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeout issues when querying instances of a local study in Orthanc #532

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

p-j-smith
Copy link
Contributor

Description

Fixes #531

  • use the DICOM timeout when getting info on the instances in a study
  • when determining if there are any instances missing, first get statistics of the study and compare the number of local and remote instances (if all instances are present locally there's no need to get the list of SOPInstanceUIDs)

Type of change

Please delete options accordingly to the description.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Suggested Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have passed on my local host device. (see further details at the CONTRIBUTING document)
  • Make sure your branch is up-to-date with main branch. See CONTRIBUTING for a general example to syncronise your branch with the main branch.
  • I have requested review to this PR.
  • I have addressed and marked as resolved all the review comments in my PR.
  • Finally, I have selected squash and merge

@p-j-smith p-j-smith requested a review from stefpiatek December 3, 2024 16:59
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.38%. Comparing base (3678f3c) to head (e26b1c2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #532      +/-   ##
==========================================
+ Coverage   87.35%   87.38%   +0.02%     
==========================================
  Files          76       76              
  Lines        3378     3386       +8     
==========================================
+ Hits         2951     2959       +8     
  Misses        427      427              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@stefpiatek stefpiatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@p-j-smith p-j-smith merged commit d0f809b into main Dec 11, 2024
11 checks passed
@p-j-smith p-j-smith deleted the paul/fix-local-query-timeout branch December 11, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Querying instances of local studies in Orthanc Raw is slow and times out
2 participants