-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of pixl_config.yml
#311
Conversation
Avoid overuse of the word `config`
The path doesn't contain only parquet files and we might use something else in the future.
Keep the config stuff together
Also use better naming: `cli_config` -> `SERVICE_SETTINGS`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works on GAE. What's more fun is that if you're using the environment then it can be done from any directory if you've used pip install -e. Which I think is okay, or do we want it to read the config only from the directory that the cli is initiated in?
I would say it's fine, not much chance that there would be any name clashes for these environment variables. |
Only risk is if you use the environment for the wrong project. e.g. I'm in dev but I use the test environment. Agree that I think its fine |
9529e56
to
f32d463
Compare
Avoids import errors during tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Attempt to reduce complexity by:
pixl_config.yml
and moving the useful bits to.env
(which already largely had the information contained inpixl_config.yml
)APIConfig
class tocli._config
config
, to avoid confusion and in preparation of Support configuration for multiple projects #309Motivation: in #309 we will add
config.yml
files to configure how projects should be run through the pipeline. The information contained in thoseconfig.yml
files are completely different from what is in the currentpixl_config.yml
file, which may lead to some confusion. In addition, the information inpixl_config.yml
is already encoded in the.env
environment variables anyway.To do
pixl_config.yml
in the docs