Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTP upload preserving directory structure #289

Merged
merged 5 commits into from
Feb 12, 2024

Conversation

jeremyestein
Copy link
Contributor

@jeremyestein jeremyestein commented Feb 9, 2024

(This code is derived from the useful bits of #274 most of which is not needed due to a requirements change)
To make FTP upload code more robust against future changes to the file layout simply upload everything as found, with no assumptions as to layout.
Document the files present at each step of the pipeline.

@jeremyestein jeremyestein requested a review from a team February 9, 2024 17:13
Copy link
Contributor

@stefpiatek stefpiatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this in Jeremy 🎉

README.md Show resolved Hide resolved
pixl_core/pyproject.toml Show resolved Hide resolved
pixl_core/src/core/upload.py Show resolved Hide resolved
@jeremyestein jeremyestein merged commit 7dc7bbd into main Feb 12, 2024
8 checks passed
@jeremyestein jeremyestein deleted the jeremy/batch-salvaged-code branch February 12, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants