Replace Docker FTPS server with `pytest` plugin fixture in `pixl_core` tests #288

milanmlft · 2024-02-08T16:11:30Z

Created an installable pytest-pixl plugin module to share fixtures across PIXL modules
Added the ftpserver fixture to spin up a local FTPS server with pyftpdlib, with support for implicit SSL
Updated pixl_core tests to use the new fixture instead of the FTPS docker

Next steps will be to also integrate this in the system test and eventually migrate all shared pytest fixtures to the pytest-pixl module.

Allows us to keep the SSL files in one place and always use the same wherever we import the module.

stefpiatek

Looking good, not sure if we're going to get circular dependencies with core

pixl_core/tests/conftest.py

pytest-pixl/src/pytest_pixl/ftpserver.py

.github/workflows/main.yml

pytest-pixl/pyproject.toml

Should avoid circular dependency.

Co-authored-by: Stef Piatek <[email protected]>

milanmlft added 11 commits February 8, 2024 12:32

Use config to set env vars in core.upload

2764115

Set up pytest-PIXL module

4a1473b

Add ftpserver fixture

23a7d7d

Add test for the ftpserver fixture

e7a9479

Move test samples into tests/ and ignore for pytest

63695fa

Move the ssl certificates inside the pytest_pixl source

69560a0

Allows us to keep the SSL files in one place and always use the same wherever we import the module.

Set pytest entrypoint for plugin

34429ef

Fix import + better typing

1ba1b8e

Replace ftp-server docker with pytest-pixl ftp server fixture

e11a9c1

Configure test to use the pytest-pixl ftps server fixture

878559a

Update installation instructions for testing pixl_core

bd9641f

milanmlft requested a review from a team February 8, 2024 16:11

Install pytest plugin also on CI runners

c3424e1

stefpiatek approved these changes Feb 8, 2024

View reviewed changes

pixl_core/tests/conftest.py Outdated Show resolved Hide resolved

pytest-pixl/src/pytest_pixl/ftpserver.py Outdated Show resolved Hide resolved

.github/workflows/main.yml Outdated Show resolved Hide resolved

pytest-pixl/pyproject.toml Outdated Show resolved Hide resolved

milanmlft added 3 commits February 8, 2024 16:24

Move core to test dependencies

9d846d5

Should avoid circular dependency.

Add copyright headers

8b73c13

Install pytest plugin correctly on CI

f399983

milanmlft force-pushed the milanmlft/fix-system-test-ftp-server branch from 2cf48fa to f399983 Compare February 8, 2024 16:30

milanmlft and others added 6 commits February 8, 2024 17:08

Add missing SSL dependency

534580b

Make sure resources are included

8f24521

Clean up CI installs

895df8d

Fix more tests

30b771b

Fix typeo

35e71bb

Co-authored-by: Stef Piatek <[email protected]>

No need to clean up as pytest.tmp_path_factory is already doing that

79ad912

milanmlft enabled auto-merge (squash) February 8, 2024 18:14

milanmlft merged commit 186e53f into main Feb 8, 2024
8 checks passed

milanmlft deleted the milanmlft/fix-system-test-ftp-server branch February 8, 2024 18:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace Docker FTPS server with `pytest` plugin fixture in `pixl_core` tests #288

Replace Docker FTPS server with `pytest` plugin fixture in `pixl_core` tests #288

milanmlft commented Feb 8, 2024

stefpiatek left a comment

Replace Docker FTPS server with pytest plugin fixture in pixl_core tests #288

Replace Docker FTPS server with pytest plugin fixture in pixl_core tests #288

Conversation

milanmlft commented Feb 8, 2024

stefpiatek left a comment

Choose a reason for hiding this comment

Replace Docker FTPS server with `pytest` plugin fixture in `pixl_core` tests #288

Replace Docker FTPS server with `pytest` plugin fixture in `pixl_core` tests #288