More accurate orthanc-anon system test #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required to run tests that hit pixl_dcmd.
pixl_dcmd needs these to persist anonmyised identifierst to postgres.
This fixes an error when trying to store the hash in the database and aligns with what the hasher endpoints return.
The existing test script checked the orthanc-anon log for receipt of a DICOM but this was not catching that the received DICOM was not being stored due problems during anonymisation. The new check script queries the orthanc-anon API to make sure it has received and stored the test DICOMs.
1 task
stefpiatek
approved these changes
Jan 31, 2024
Co-authored-by: Stef Piatek <[email protected]>
Co-authored-by: Stef Piatek <[email protected]>
…CLH-Foundry/PIXL into jstutters/205-orthanc-anon-system-test
|
system-test runs to completion outside Actions so speculative commits incoming. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some problems with the DICOM anonymisation process in the test environment (missing envvars, persisting of hashes to DB) and ensures that orthanc-anon has received and stored the test DICOMs.