Fix broken local serve due to azure logging middleware failure #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28
When docker compose is used (for
serve-local
), it sets any unset variables as empty strings in the container environment. So, as would be typical for local scenarios not using application insights, when unset, the logging initialisation fails as it only catches for the env var beingNone
, when it also needs to catch for empty strings.Have amended with a check before the logging is initialised, which will skip if the
APPLICATIONINSIGHTS_CONNECTION_STRING
isNone
or""
, logging a warning message to the console if so