Rendering tweaks #39
Merged
Rendering tweaks #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the cap to 60, the flickering I reported no longer happens. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting "pb_push_to: begin-end block musn't exceed 128 dwords" log spam when I enabled logging. I was sending way more than 128 DWORDs which seemed to work okay so not sure why the limit but I meet it now mostly anyway
Also I think I have fixed the random flickering by waiting on the vblank event instead of manual frame timing.
pkbit now uses two buffers instead of 3 (saves ~3.5MB of RAM in 720p)