Add language localisation for all missing items #171
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add language localisation for all missing items
Remove unused AutoloadDlcAndUpdateAddedMessage
First attempt was not passing through the region information for the language and was only using the Language itself, e.g. "zh_TW" was Chinese Simplified not Chinese Traditional, this has now been fixed so that Region information is also used when converting, confirmed that new items in "zh_TW" are now using Traditional Chinese.
Created a utilty which uses the publicly accessible Google Translate to find all missing locale items and translate them, the utility preserves all original encoding and translations and only adds the missing ones, please help me to confirm the language conversions are good. I did consider sorting all of them so that the locales are all in alphabetical order of name, but that would have caused us to lose our ability to diff these accurately, so left them in the order they are in as much as possible.
For some reason it is complaining about bidirectional unicode characters, but these were already in there, I can regenerate them and not use the JavaScriptEncoder.UnsafeRelaxedJsonEscaping encoder, but this will then end up modifying a lot of these items using /uxxxx syntax instead which I feel is not ideal.