Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language localisation for all missing items #171

Conversation

amurgshere
Copy link
Contributor

Add language localisation for all missing items
Remove unused AutoloadDlcAndUpdateAddedMessage

First attempt was not passing through the region information for the language and was only using the Language itself, e.g. "zh_TW" was Chinese Simplified not Chinese Traditional, this has now been fixed so that Region information is also used when converting, confirmed that new items in "zh_TW" are now using Traditional Chinese.

Created a utilty which uses the publicly accessible Google Translate to find all missing locale items and translate them, the utility preserves all original encoding and translations and only adds the missing ones, please help me to confirm the language conversions are good. I did consider sorting all of them so that the locales are all in alphabetical order of name, but that would have caused us to lose our ability to diff these accurately, so left them in the order they are in as much as possible.

For some reason it is complaining about bidirectional unicode characters, but these were already in there, I can regenerate them and not use the JavaScriptEncoder.UnsafeRelaxedJsonEscaping encoder, but this will then end up modifying a lot of these items using /uxxxx syntax instead which I feel is not ideal.

- zh_TW is now correctly using Traditional Chinese
Removed unused AutoloadDlcAndUpdateAddedMessage
@github-actions github-actions bot added the gui Affects the Avalonia UI or translations. label Nov 3, 2024
@amurgshere
Copy link
Contributor Author

Hey @GreemDev ,

I have created this as a Draft for now, the tool has been fixed to use the correct language for Chinese Simplified vs Traditional.

I have put the tool on GitHub, you can find it here:

https://github.com/amurgshere/LanguageLocaliser

Thank You.

@amurgshere
Copy link
Contributor Author

Hey @WilliamWsyHK ,

Are you able to check out the translations for Chinese in this one and let me know if there are still issues?

Thank You.

@WilliamWsyHK
Copy link
Contributor

I have already commented yesterday on the file, and one of the translations is painfully wrong.
Please I am begging you not to translate any languages you don't know.

Adding the English in each of the locale is already good enough to fill up those gaps so that those people who know that language can at least start from somewhere.

@GreemDev GreemDev closed this Nov 4, 2024
@amurgshere
Copy link
Contributor Author

Ok then no problem, just trying to help @WilliamWsyHK , will leave the translation to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gui Affects the Avalonia UI or translations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants