Merge branch 'master' into master

Ryubing · Dec 28, 2024 · 17efbd8 · 17efbd8
2 parents ee7e229 + 709eeda
commit 17efbd8
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/.github/workflows/nightly_pr_comment.yml b/.github/workflows/nightly_pr_comment.yml
@@ -41,12 +41,13 @@ jobs:
             let hidden_headless_artifacts = `\n\n <details><summary>GUI-less</summary>\n`;
             let hidden_debug_artifacts = `\n\n <details><summary>Only for Developers</summary>\n`;
             for (const art of artifacts) {
+              var url = `https://github.com/Ryubing/Ryujinx/actions/runs/${run_id}/artifacts/${art_id}`;
               if(art.name.includes('Debug')) {
-                hidden_debug_artifacts += `\n* [${art.name}](https://nightly.link/${owner}/${repo}/actions/artifacts/${art.id}.zip)`;
+                hidden_debug_artifacts += `\n* [${art.name}](${url})`;
               } else if(art.name.includes('nogui-ryujinx')) {
-                hidden_headless_artifacts += `\n* [${art.name}](https://nightly.link/${owner}/${repo}/actions/artifacts/${art.id}.zip)`;
+                hidden_headless_artifacts += `\n* [${art.name}](${url})`;
               } else {
-                body += `\n* [${art.name}](https://nightly.link/${owner}/${repo}/actions/artifacts/${art.id}.zip)`;
+                body += `\n* [${art.name}](${url})`;
               }
             }
             hidden_headless_artifacts += `\n</details>`;

diff --git a/src/Ryujinx.Graphics.Metal.SharpMetalExtensions/NSHelper.cs b/src/Ryujinx.Graphics.Metal.SharpMetalExtensions/NSHelper.cs
@@ -1,19 +1,23 @@
 using SharpMetal.Foundation;
 using SharpMetal.ObjectiveCCore;
 using System.Runtime.Versioning;
+// ReSharper disable InconsistentNaming
 
 namespace Ryujinx.Graphics.Metal.SharpMetalExtensions
 {
     [SupportedOSPlatform("macOS")]
     public static class NSHelper
     {
+        private static readonly Selector sel_getCStringMaxLengthEncoding = "getCString:maxLength:encoding:";
+        private static readonly Selector sel_stringWithUTF8String = "stringWithUTF8String:";
+
         public static unsafe string ToDotNetString(this NSString source)
         {
             char[] sourceBuffer = new char[source.Length];
             fixed (char* pSourceBuffer = sourceBuffer)
             {
                 ObjectiveC.bool_objc_msgSend(source,
-                    "getCString:maxLength:encoding:",
+                    sel_getCStringMaxLengthEncoding,
                     pSourceBuffer,
                     source.MaximumLengthOfBytes(NSStringEncoding.UTF16) + 1,
                     (ulong)NSStringEncoding.UTF16);
@@ -23,6 +27,6 @@ public static unsafe string ToDotNetString(this NSString source)
         }
 
         public static NSString ToNSString(this string source) 
-            => new(ObjectiveC.IntPtr_objc_msgSend(new ObjectiveCClass("NSString"), "stringWithUTF8String:", source));
+            => new(ObjectiveC.IntPtr_objc_msgSend(new ObjectiveCClass(nameof(NSString)), sel_stringWithUTF8String, source));
     }
 }