Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle odd keys #459

Merged
merged 2 commits into from
Dec 17, 2024
Merged

fix: handle odd keys #459

merged 2 commits into from
Dec 17, 2024

Conversation

dignifiedquire
Copy link
Member

@dignifiedquire dignifiedquire commented Nov 13, 2024

Ther are two issues with oddly formed keys that were not properly handled

  • avoid using - to avoid a subtraction with overflow for pkcs
  • always validate the key in from_components to avoid errors in the internal precompute

@tarcieri
Copy link
Member

I’m reminded of #445

@dignifiedquire
Copy link
Member Author

yes, but the goal here is not general security, but rather for a first step remove unusable keys

once we have a solution for #445 this can be folded in

@dignifiedquire dignifiedquire changed the title fix: handle tiny keys fix: handle odd keys Nov 18, 2024
@dignifiedquire dignifiedquire merged commit 9956b8f into master Dec 17, 2024
11 checks passed
@dignifiedquire dignifiedquire deleted the fix-small-keys branch December 17, 2024 11:06
@dignifiedquire
Copy link
Member Author

already published on the 0.9.x branch, so merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants