Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pss: support DecodePrivateKey and DecodePublicKey traits #424

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

lumag
Copy link
Contributor

@lumag lumag commented Mar 27, 2024

Implement necessary conversion traits to enable DecodePrivateKey and DecodePublicKey traits implementation.

lumag added 3 commits March 27, 2024 10:28
RSA PSS keys can be used either with the old rsaEncryption OID or with
the id-RSASSA-PSS, while PKCS1v15 are limited to rsaEncryption. Enforce
this limitation before adding support for is-RSASSA-PSS handling.

Signed-off-by: Dmitry Baryshkov <[email protected]>
Allow both rsaEncoding and id-RSASSA-PSS OIDs in verify_algorithm_id().

Signed-off-by: Dmitry Baryshkov <[email protected]>
Implement necessary conversion traits to enable DecodePrivateKey and
DecodePublicKey traits implementation.

Signed-off-by: Dmitry Baryshkov <[email protected]>
Copy link
Member

@tarcieri tarcieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, although I'm curious if these keys support anything besides just an alternative OID. Anyway, this should be sufficient to close #422.

@tarcieri
Copy link
Member

It seems the OID is from RFC7427 but it doesn't say anything about its usage in PKCS#8. Anyway, merging.

@tarcieri tarcieri merged commit e54fb7d into RustCrypto:master Mar 27, 2024
9 checks passed
@tarcieri tarcieri mentioned this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants