srp: compute K = H(S) correctly.
#166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to [the specification] section _The SRP protocol_, `K` (which corresponds to the session key) is computed as follows: ``` K = H(S) ``` where `H` is the digest algorithm, and `S` is the common exponential value. In the [current implementation], `K` is equal to `S`, which does not follow the SRP protocol specification. This commit fixes this issue by computing the right value for `K`. [the specification]: http://srp.stanford.edu/ndss.html#SECTION00032200000000000000 [current implementation]: https://github.com/RustCrypto/PAKEs/blob/8e46d6bfa24d44e6671616d730e978157b2b23e3/srp/src/client.rs#L211
|
up |
|
@zadlg your opinion on the existing PRs and any overlap and existing discussion would be appreciated |
|
Sorry, I didn't understand you were waiting for an answer from me. I think the specification is quite clear, isn't it ? |
|
Let me be a little more explicit:
|
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
srp: compute
K = H(S)correctly.According to the specification section The SRP protocol,
K(which correspondsto the session key) is computed as follows:
where
His the digest algorithm, andSis the common exponential value.In the current implementation,
Kis equal toS, which does not followthe SRP protocol specification.
This commit fixes this issue by computing the right value for
K.