Skip to content

Commit

Permalink
gve: fix the wrong AdminQ buffer queue index check
Browse files Browse the repository at this point in the history
The 'tail' and 'head' are 'unsigned int' type free-running count, when
'head' is overflow, the 'int i (= tail) < u32 head' will be false:

Only '- loop 0: idx = 63' result is shown, so it needs to use 'int' type
to compare, it can handle the overflow correctly.

typedef uint32_t u32;

int main()
{
        u32 tail, head;
        int stail, shead;
        int i, loop;

        tail = 0xffffffff;
        head = 0x00000000;

        for (i = tail, loop = 0; i < head; i++) {
                unsigned int idx = i & 63;

                printf("+ loop %d: idx = %u\n", loop++, idx);
        }

        stail = tail;
        shead = head;
        for (i = stail, loop = 0; i < shead; i++) {
                unsigned int idx = i & 63;

                printf("- loop %d: idx = %u\n", loop++, idx);
        }

        return 0;
}

Fixes: 5cdad90 ("gve: Batch AQ commands for creating and destroying queues.")
Signed-off-by: Haiyue Wang <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
haiyuewa authored and davem330 committed Jan 28, 2022
1 parent 501c8f5 commit 1f84a94
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/ethernet/google/gve/gve_adminq.c
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ static int gve_adminq_parse_err(struct gve_priv *priv, u32 status)
*/
static int gve_adminq_kick_and_wait(struct gve_priv *priv)
{
u32 tail, head;
int tail, head;
int i;

tail = ioread32be(&priv->reg_bar0->adminq_event_counter);
Expand Down

0 comments on commit 1f84a94

Please sign in to comment.