Dp24 exclude file #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stevieing Perhaps it is once the struct becomes public? A bug? |
stevieing
reviewed
Sep 4, 2024
| @@ -26,8 +26,8 @@ mod generics; | |||
| mod tpf_fasta; | |||
| use crate::tpf_fasta::tpf_fasta_mod::curate_fasta; | |||
|
|
|||
| mod exclude_seq; | |||
| use crate::exclude_seq::exclude_seq_mod::filter_fasta; | |||
| mod filter_fasta; | |||
There was a problem hiding this comment.
Just wondering why we need to do this? Is this standard in Rust. We have had to do it in a few places when adding tests and not entirely sure why.
Maybe. Not sure. At the moment we need to expose them publicly because it is the only way we can create a struct. I suspect a better way would be to use initializers / factory functions. |
stevieing
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated exclide_seq -> filterfasta to also take a names.lst file on names to exclude from final fasta. closes #47.