CI: upgrade GCC baseline from 4.8 -> 5.4 (5.5) #3262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesamesam
force-pushed
the
gcc-baseline
branch
2 times, most recently
from
834cfd7
to
c9f480f
Compare
|
Great, thanks! I was meaning to file an Issue for this -- now we've got a Pull Request already! :-D |
tschwinge
reviewed
Nov 22, 2024
thesamesam
force-pushed
the
gcc-baseline
branch
from
c9f480f
to
df79b77
Compare
thesamesam
changed the title
thesamesam
added a commit
to thesamesam/gccrs
that referenced
this pull request
Nov 23, 2024
This was pointed out by tschwinge in a review [0]. Add a note to avoid that error happening in future. [0] Rust-GCC#3262 (comment) ChangeLog: * .github/workflows/ccpp.yml: Add note to keep in sync with .github/bors.toml.
dkm
reviewed
Nov 23, 2024
|
I've removed all bors mention/files in #3263 |
powerboat9
reviewed
Nov 23, 2024
thesamesam
force-pushed
the
gcc-baseline
branch
from
a146b89
to
bf08887
Compare
GCC's baseline was changed from C++11 -> C++14 and GCC 4.8 -> GCC 5.4 in r15-4719-ga9ec1bc06bd3cc, so adjust the baseline CI job accordingly. One quirk here is that the Ubuntu image we're using in CI has 5.5.0 rather than 5.4.0. But I think we can eat that difference. ChangeLog: * .github/workflows/ccpp.yml: Use GCC 5.5 instead of GCC 4.8.
thesamesam
force-pushed
the
gcc-baseline
branch
from
bf08887
to
699b987
Compare
|
It's not auto-merging, seemingly because |
|
@powerboat9: Yeah, probably. Where does it get that from, do you (or anyone else, of course) happen to know? I could easily push this manually, but not sure I should? Maybe wait for the pros to be back on Monday. ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC's baseline was changed from C++11 -> C++14 and GCC 4.8 -> GCC 5.4
in r15-4719-ga9ec1bc06bd3cc, so adjust the baseline CI job accordingly.
One quirk here is that the Ubuntu image we're using in CI has 5.5.0
rather than 5.4.0. But I think we can eat that difference.
ChangeLog:
* .github/workflows/ccpp.yml: Use GCC 5.5 instead of GCC 4.8.
* .github/bors.toml: Update CI job name.