Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent execution of some nr1.0 functions with nr2.0 #3257

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Prevent execution of some nr1.0 functions with nr2.0 #3257

merged 1 commit into from
Nov 22, 2024

Conversation

powerboat9
Copy link
Contributor

@powerboat9 powerboat9 commented Nov 21, 2024 •
edited
Loading

This should make some common dependencies on the old resolver easier to debug

@powerboat9
Prevent execution of some nr1.0 functions with nr2.0
aff2d76 
gcc/rust/ChangeLog:

	* resolve/rust-name-resolver.cc: Include options.txt.
	(Resolver::insert_resolved_name): Assert that name resolution
	2.0 is disabled.
	(Resolver::lookup_resolved_name): Likewise.
	(Resolver::insert_resolved_type): Likewise.
	(Resolver::lookup_resolved_type): Likewise.
	(Resolver::insert_resolved_label): Likewise.
	(Resolver::lookup_resolved_label): Likewise.
	(Resolver::insert_resolved_macro): Likewise.
	(Resolver::lookup_resolved_macro): Likewise.
	(Resolver::insert_resolved_misc): Likewise.
	(Resolver::lookup_resolved_misc): Likewise.

Signed-off-by: Owen Avery <[email protected]>
P-E-P
P-E-P approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@P-E-P P-E-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea

@P-E-P P-E-P added this pull request to the merge queue Nov 22, 2024
CohenArthur
CohenArthur approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@CohenArthur CohenArthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I like that idea!

Merged via the queue into Rust-GCC:master with commit eb1c8e4 Nov 22, 2024
12 checks passed
@powerboat9 powerboat9 deleted the block branch November 22, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CohenArthur CohenArthur CohenArthur approved these changes

@P-E-P P-E-P P-E-P approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@powerboat9 @P-E-P @CohenArthur