Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binder limitations documentation added #229

Merged
merged 3 commits into from
Oct 11, 2022

Conversation

zwimer
Copy link
Contributor

@zwimer zwimer commented Sep 20, 2022

This PR adds documentation about some of binder's limitations. Right now, it is focussed mostly on operatos.

I am not sure how to generate the docs from my file, though I verified the limitations.rst is as I desire via rst2pdf.

@zwimer
Copy link
Contributor Author

zwimer commented Sep 20, 2022

Related:
#220
#225
#226
#227
#228

Copy link
Member

@lyskov lyskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Could you please update it so it reflect recent merges? Thanks,

@zwimer
Copy link
Contributor Author

zwimer commented Oct 11, 2022

I did with the most recent commits! Though, if you plan to merge #237 then I would hold off on merging this, as it will require an update for that PR as well- or we could update the docs this PR creates in that PR instead if preferred.

@lyskov
Copy link
Member

lyskov commented Oct 11, 2022

Thank you @zwimer ! I think lets merge this now and when/if #237 is merged then it related doc update could be included in it.

Copy link
Member

@lyskov lyskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, - thank you for putting this together @zwimer !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants