fix: lsp bugs #579
Open
fix: lsp bugs #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dingyi222666
suggested changes
Apr 3, 2024
| val diff = startIndex - endIndex | ||
| endIndex = startIndex | ||
| startIndex = endIndex - diff | ||
| editList.forEach { list: ArrayList<TextEdit> -> |
There was a problem hiding this comment.
No changes needed here. Consider modifying completionItem.additionalTextEdits at
listOf, and then test to see if it works properly.
| @@ -81,13 +81,9 @@ class DocumentChangeEvent : AsyncEventListener() { | |||
| editor: LspEditor, | |||
| data: ContentChangeEvent | |||
| ): List<TextDocumentContentChangeEvent> { | |||
| val text = data.changedText.toString() | |||
| val text = data.editor.text.toString() | |||
There was a problem hiding this comment.
This does not comply with the LSP specification; what is required here is text for an incremental change. Please clarify why there is a need to modify this part, and if possible, provide a project that can reproduce the related bug. I will look into it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.