Documentation and improvements #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauruns
requested changes
Aug 22, 2023
| target_include_directories(dpdk_msr4_rx PUBLIC ${CMAKE_SOURCE_DIR}/include) | ||
| target_link_libraries(dpdk_msr4_rx ${DPDK_LIBRARIES}) | ||
| target_link_libraries(dpdk_msr4_rx ${DPDK_LIBRARIES} zmq) |
There was a problem hiding this comment.
This dependency has to be flagged with USE_ZMQ, too.
| #define CALIB_SKIP_DURATION 1 // 1s, give calibration enough time to finish before processing packets again | ||
| #define IQ_FILES_BASE_PATH "/tmp/iq_dump/" //where to store the iq dumps | ||
|
|
||
| #define CHUNK_SIZE 131072 //this is the size of a buffer that gets forwarded using zmq. WRITE_BUFFER_SIZE % CHUNK_SIZE should 0. |
There was a problem hiding this comment.
As these are macros, you can add a static_assert to check this condition.
|
|
||
| // Port configuration | ||
| struct rte_eth_conf port_conf = { | ||
| /* |
There was a problem hiding this comment.
I think you can remove the commented code.
| } | ||
|
|
||
| static int launch_lcores(__rte_unused void *dummy) | ||
| { | ||
| // Get lcore id | ||
| int lcore_id = rte_lcore_id(); | ||
|
|
||
| if (lcore_id <= 4) | ||
| if (lcore_id > 0 && lcore_id < NB_PORTS + 1) |
There was a problem hiding this comment.
Suggested change
| if (lcore_id > 0 && lcore_id < NB_PORTS + 1) | |
| if (lcore_id > 0 && lcore_id <= NB_PORTS) |
| lcore_rx(); | ||
| } | ||
| else if (lcore_id >= 5 && lcore_id <= 8) | ||
| else if (lcore_id > NB_PORTS && lcore_id < 2 * NB_PORTS + 1) |
There was a problem hiding this comment.
Suggested change
| else if (lcore_id > NB_PORTS && lcore_id < 2 * NB_PORTS + 1) | |
| else if (lcore_id > NB_PORTS && lcore_id <= 2 * NB_PORTS) |
| { | ||
| // Lcores 5-8 handle file dump | ||
| // Lcores for file dump | ||
| lcore_dump(); | ||
| } | ||
| else |
There was a problem hiding this comment.
Do you need the else branch if it is empty? Or did you remove the exception by accident?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.