-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Km.24 hour input exploration #1274
base: main
Are you sure you want to change the base?
Conversation
|
✅ Deploy Preview for astro-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for astro-stencil ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Co-authored-by: Maria Paterno <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Brief Description
--WIP --
This is a proof of concept for a new Astro Component for forces 24hour/12hour time input. It uses iMaskJs for masking.
The component is basically complete with just review and bug reports to work through, however, this PR also needs cleaning up and storybook additions before committing.
Update 1/22 - removed the 12hour masking functionality in favor of
type="time"
when 24h is not chosenTODO:
JIRA Link
R2C2-119
Related Issue
General Notes
Motivation and Context
This exploration of new components was undertaken because
<rux-input type="time">
is not as flexible as it could be regarding time input. There have been several requests from members of the current project for a component capable of forcing 24h time input.Issues and Limitations
There are still a couple of bugs I'd like to sort out at this time:
include-seconds
/ changingtimeformat
after first render will not actually change the input masking. This should be handled.Types of changes
Checklist