Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve videoconf client-side error handling #34069

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

chore: improve videoconf client-side error handling #34069

wants to merge 1 commit into from
+106 −54

Conversation

pierre-lehnen-rc
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@pierre-lehnen-rc pierre-lehnen-rc marked this pull request as ready for review November 27, 2024 15:43
@pierre-lehnen-rc pierre-lehnen-rc requested a review from a team as a code owner November 27, 2024 15:43
@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Nov 27, 2024 •
edited
Loading

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 27, 2024

⚠️ No Changeset found

Latest commit: d1e11b9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov Codecov
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.79%. Comparing base (b8388ab) to head (d1e11b9).
Report is 6 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #34069   +/-   ##
========================================
  Coverage    75.79%   75.79%           
========================================
  Files          510      510           
  Lines        22063    22063           
  Branches      5385     5385           
========================================
  Hits         16723    16723           
  Misses        4694     4694           
  Partials       646      646
Flag Coverage Δ
unit 75.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions GitHub Actions
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34069/
on branch gh-pages at 2024-11-27 15:49 UTC

tassoevan
tassoevan approved these changes Nov 29, 2024
View reviewed changes
apps/meteor/client/lib/VideoConfManager.ts
this.incomingDirectCalls.set(callId, newData);
}

private emitError(error = 'error-videoconf-unexpected'): void {
this.emit('error', { error });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider emitting a subclass of RocketChatError (from apps/meteor/client/lib/errors) instead.

@dougfabris dougfabris added this to the 7.2.0 milestone Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tassoevan tassoevan tassoevan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pierre-lehnen-rc @tassoevan @dougfabris