-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: improve locator of sidebar collapser #34066
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34066 +/- ##
========================================
Coverage 75.79% 75.79%
========================================
Files 510 510
Lines 22063 22063
Branches 5385 5385
========================================
Hits 16723 16723
Misses 4694 4694
Partials 646 646
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes (including videos or screenshots)
When the group is collapsed, the title concatenates with the unread title, so the locator
exact
will fail. For the locator to be exact we need to filter by the inner childheading
.Issue(s)
Steps to test or reproduce
Further comments