regression: UserAvatar should always render BaseAvatar

[dougfabris]

Proposed changes (including videos or screenshots)

Introduced here: #32906

Previously we didn't check userId or username to render BaseAvatar, neither throw an Error. There are some cases that username can be undefined such as ComposerBoxPopupUser which will break the entire UI if we keep the current solution. The PR aims to always render the BaseAvatar as we were doing before, because this component has an error validation when trying to load an invalid URL, rendering a Skeleton as a fallback

Issue(s)

Steps to test or reproduce

Further comments

CORE-834

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: 41445d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34061/
on branch gh-pages at 2024-11-26 19:51 UTC

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.75%. Comparing base (97edecc) to head (f934f58).

Additional details and impacted files

@@              Coverage Diff               @@
##           release-7.1.0   #34061   +/-   ##
==============================================
  Coverage          75.75%   75.75%           
==============================================
  Files                510      510           
  Lines              22078    22078           
  Branches            5387     5387           
==============================================
  Hits               16726    16726           
  Misses              4706     4706           
  Partials             646      646           

Flag	Coverage Δ
unit	75.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[ggazzo]

how is this possible? a function that accepts an empty object will return something?

[dougfabris]

@ggazzo did you checked the function?

[ggazzo]

sure and still makes no sense rendering something if you have no info about thats why this params are wrong

you are trying to fix a different problem with a "naive" solution

your problem is the /invite @something breaking right ?

for a small fraction the autocomplete uses one render type for a different item list thats why username is undefined there. but this is the real problema.

even this change solves the issue, I think you are covering the wrong place