feat: apps-engine timeout config #33690
Merged
+23
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 50087bc The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33690 +/- ##
========================================
Coverage 75.42% 75.42%
========================================
Files 493 493
Lines 21499 21499
Branches 5337 5337
========================================
Hits 16215 16215
Misses 4644 4644
Partials 640 640
Flags with carried forward coverage won't be shown. Click here to find out more. |
KevLehman
approved these changes
Oct 21, 2024
KevLehman
reviewed
Oct 21, 2024
d-gubert
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
d-gubert
added a commit
to RocketChat/Rocket.Chat.Apps-engine
that referenced
this pull request
Dec 4, 2024
This was referenced Dec 4, 2024
d-gubert
added a commit
to RocketChat/Rocket.Chat.Apps-engine
that referenced
this pull request
Dec 5, 2024
- [make Deno capture unhandled exceptions and rejections and report them to the server](RocketChat/Rocket.Chat#33997) - [apps-engine timeout config](RocketChat/Rocket.Chat#33690)
d-gubert
added a commit
to RocketChat/Rocket.Chat.Apps-engine
that referenced
this pull request
Dec 6, 2024
d-gubert
added a commit
to RocketChat/Rocket.Chat.Apps-engine
that referenced
this pull request
Dec 6, 2024
d-gubert
added a commit
to RocketChat/Rocket.Chat.Apps-engine
that referenced
this pull request
Dec 6, 2024
This was referenced Dec 9, 2024
|
/backport 7.0.1 |
|
Pull request #34147 added to Project: "Patch 7.0.1" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Make the Apps-Engine runtime accept the
APPS_ENGINE_RUNTIME_TIMEOUTenvironment variable to configure the time limit for requests to the Deno subprocess.Also, makes calls to
Preapp event methods follow the same "global" timeout, instead of the shorter 1 second.We've had reports of some environments having timeouts where the request was actually expected to take a longer time to resolve.
Default timeout is increased to 30 seconds
Issue(s)
SUP-690
SUP-688
Closes #33834
Steps to test or reproduce
Further comments