Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: E2EE not rendering new navigation feature preview #33631

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

hugocostadev
Copy link
Contributor

@hugocostadev hugocostadev commented Oct 17, 2024

Proposed changes (including videos or screenshots)

Added the check for displaying the RoomBody from feature preview to E2EE rooms

Issue(s)

Steps to test or reproduce

Further comments

https://rocketchat.atlassian.net/browse/E2EE2-86

@hugocostadev hugocostadev requested a review from a team as a code owner October 17, 2024 17:41
Copy link
Contributor

dionisio-bot bot commented Oct 17, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 17, 2024

🦋 Changeset detected

Latest commit: c27cf06

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 33 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hugocostadev hugocostadev added this to the 7.0 milestone Oct 17, 2024
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33631/
on branch gh-pages at 2024-10-17 18:15 UTC

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.85%. Comparing base (bed0d40) to head (c27cf06).
Report is 13 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33631   +/-   ##
========================================
  Coverage    74.85%   74.85%           
========================================
  Files          470      470           
  Lines        20743    20743           
  Branches      5294     5294           
========================================
  Hits         15528    15528           
  Misses        4595     4595           
  Partials       620      620           
Flag Coverage Δ
unit 74.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo merged commit d879c8b into develop Oct 18, 2024
51 checks passed
@ggazzo ggazzo deleted the fix/e2ee-room-body branch October 18, 2024 02:51
This was referenced Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants