Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Contact channels and history tab #32595

Merged
merged 6 commits into from
Oct 17, 2024

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Jun 12, 2024

Proposed changes (including videos or screenshots)

Screenshot 2024-10-17 at 19 12 45

Screenshot 2024-10-17 at 19 12 38

Issue(s)

Steps to test or reproduce

Further comments

SCI-13
SCI-14

Copy link
Contributor

dionisio-bot bot commented Jun 12, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jun 12, 2024

⚠️ No Changeset found

Latest commit: 3fea7c7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.38%. Comparing base (5e98135) to head (3fea7c7).
Report is 190 commits behind head on feat/single-contact-id.

Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                     @@
##           feat/single-contact-id   #32595       +/-   ##
===========================================================
+ Coverage                   58.43%   74.38%   +15.95%     
===========================================================
  Files                        2744      471     -2273     
  Lines                       66280    20923    -45357     
  Branches                    15001     5344     -9657     
===========================================================
- Hits                        38732    15564    -23168     
+ Misses                      24717     4723    -19994     
+ Partials                     2831      636     -2195     
Flag Coverage Δ
e2e ?
e2e-api ?
unit 74.38% <ø> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris force-pushed the feat/contact-contextual-bar branch from 8ae7a05 to ddf8445 Compare June 17, 2024 22:22
@dougfabris dougfabris force-pushed the feat/contact-contextual-bar branch 4 times, most recently from d73d686 to 59b53ff Compare July 4, 2024 19:23
@dougfabris dougfabris force-pushed the feat/single-contact-id branch 3 times, most recently from 30e5f03 to a17f84c Compare August 8, 2024 13:22
@dougfabris dougfabris closed this Aug 8, 2024
@dougfabris dougfabris force-pushed the feat/contact-contextual-bar branch from 30367e0 to a17f84c Compare August 8, 2024 19:19
@dougfabris dougfabris reopened this Aug 8, 2024
@dougfabris dougfabris force-pushed the feat/single-contact-id branch 3 times, most recently from 2b90fb7 to 56c685c Compare August 20, 2024 14:42
@dougfabris dougfabris force-pushed the feat/single-contact-id branch 3 times, most recently from a39f3c8 to 094b155 Compare October 15, 2024 14:01
@dougfabris dougfabris force-pushed the feat/contact-contextual-bar branch from 9a61871 to f2242c3 Compare October 16, 2024 13:44
Copy link
Contributor

github-actions bot commented Oct 16, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-32595/
on branch gh-pages at 2024-10-17 23:01 UTC

@dougfabris dougfabris force-pushed the feat/contact-contextual-bar branch from f2242c3 to b8f04c3 Compare October 16, 2024 15:11
@dougfabris dougfabris changed the title feat: New Omnichannel Contact Tab feat: Contact channels tab Oct 16, 2024
@dougfabris dougfabris changed the title feat: Contact channels tab feat: Contact channels and history tab Oct 16, 2024
@dougfabris dougfabris force-pushed the feat/contact-contextual-bar branch from a7fdf73 to 898a9d5 Compare October 17, 2024 22:04
@dougfabris dougfabris force-pushed the feat/contact-contextual-bar branch from 898a9d5 to 3fea7c7 Compare October 17, 2024 22:43
@dougfabris dougfabris marked this pull request as ready for review October 17, 2024 23:26
@dougfabris dougfabris requested a review from a team as a code owner October 17, 2024 23:26
Copy link
Contributor

@pierre-lehnen-rc pierre-lehnen-rc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backend ok

@dougfabris dougfabris merged commit b923f2d into feat/single-contact-id Oct 17, 2024
39 of 41 checks passed
@dougfabris dougfabris deleted the feat/contact-contextual-bar branch October 17, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants