fix: Custom sounds not working when storage is set to filesystem (#33424

)

.changeset/seven-hotels-collect.md

@@ -0,0 +1,5 @@
+---
+"@rocket.chat/meteor": patch
+---
+
+Fixes a problem with custom sounds causing files to not be playable when using filesystem storage.

apps/meteor/app/custom-sounds/server/startup/custom-sounds.js

@@ -76,6 +76,7 @@ Meteor.startup(() => {
 		} else {
 			res.setHeader('Last-Modified', new Date().toUTCString());
 		}
+
 		res.setHeader('Content-Type', file.contentType);
 		res.setHeader('Content-Length', file.length);
 

apps/meteor/app/file/server/file.server.ts

@@ -6,6 +6,7 @@ import stream from 'stream';
 
 import type { ObjectId } from 'bson';
 import { MongoInternals } from 'meteor/mongo';
+import mime from 'mime-type/with-db';
 import mkdirp from 'mkdirp';
 import type { GridFSBucketReadStream } from 'mongodb';
 import { GridFSBucket } from 'mongodb';
@@ -166,11 +167,13 @@ class FileSystem implements IRocketChatFileStore {
 			const rs = this.createReadStream(fileName);
 			return {
 				readStream: rs,
-				// contentType: file.contentType
+				// We currently don't store the content type of uploaded custom sounds when using
+				// The filesystem storage. We will use mime to infer its type from the extension.
+				contentType: (mime.lookup(fileName) as string) || 'application/octet-stream',
 				length: stat.size,
 			};
 		} catch (error1) {
-			//
+			console.error(error1);
 		}
 	}
 
@@ -197,7 +200,7 @@ class FileSystem implements IRocketChatFileStore {
 		try {
 			return await this.remove(fileName);
 		} catch (error1) {
-			//
+			console.error(error1);
 		}
 	}
 }