improvements

RocketChat · Oct 17, 2024 · 503cfc9 · 503cfc9
1 parent 8ce7c6d
commit 503cfc9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/apps/meteor/app/importer/server/classes/converters/ConverterCache.ts b/apps/meteor/app/importer/server/classes/converters/ConverterCache.ts
@@ -62,7 +62,7 @@ export class ConverterCache {
 		this.addUser(userData.importIds[0], userData._id, userData.username);
 	}
 
-	addUserNameToId(username: string, id: string): void {
+	addUsernameToId(username: string, id: string): void {
 		this._userNameToIdCache.set(username, id);
 	}
 
@@ -215,7 +215,7 @@ export class ConverterCache {
 		}
 
 		const user = await Users.findOneByUsername(username, { projection: { _id: 1 } });
-		this._userNameToIdCache.set(username, user?._id);
+		this.addUsernameToId(username, user?._id);
 
 		return user?._id;
 	}

diff --git a/apps/meteor/app/livechat/server/lib/Contacts.ts b/apps/meteor/app/livechat/server/lib/Contacts.ts
@@ -358,7 +358,7 @@ export async function createContact(params: CreateContactParams, upsertId?: ILiv
 		channels,
 		customFields,
 		unknown,
-		importIds,
+		...(importIds?.length ? { importIds } : {}),
 	} as const;
 
 	// Use upsert when doing auto-migration so that if there's multiple requests processing at the same time, they won't interfere with each other