chore: split Contacts.ts file and its tests into separate files for every function #28148
pierre-lehnen-rcci.yml
on: pull_request
⚙️ Variables Setup
3s
Builds matrix rust bindings against alpine
6s
Matrix: 🔎 Code Check / code-check
deploy-preview
2m 50s
Matrix: 🚢 Build Docker Images for Testing
Matrix: 🔨 Test API (EE) / test
Waiting for pending jobs
Matrix: 🔨 Test API (CE) / test
Waiting for pending jobs
Matrix: 🔨 Test UI (EE) / test
Waiting for pending jobs
Matrix: 🔨 Test UI (EE) / test
Waiting for pending jobs
Matrix: 🔨 Test UI (CE) / test
Waiting for pending jobs
Matrix: 🚢 Build Docker Images for Production
Matrix: 🚀 Publish Docker Image (main)
Matrix: 🚀 Publish Docker Image (services)
🚀 Notify external services
0s
trigger-dependent-workflows
0s
Update Version Durability
/
update-versions
Annotations
7 errors and 19 warnings
|
🔎 Code Check / TypeScript
@rocket.chat/meteor#typecheck: command (/home/runner/work/Rocket.Chat/Rocket.Chat/apps/meteor) /tmp/xfs-d4556525/yarn run typecheck exited (2)
|
|
🔎 Code Check / TypeScript
Cannot find module './contacts/getContactManagerIdByUsername' or its corresponding type declarations.
|
|
🔎 Code Check / TypeScript
Process completed with exit code 2.
|
|
🔎 Code Check / Code Lint
@rocket.chat/meteor#lint: command (/home/runner/work/Rocket.Chat/Rocket.Chat/apps/meteor) /tmp/xfs-b1836f4c/yarn run lint exited (1)
|
|
🔎 Code Check / Code Lint:
apps/meteor/app/livechat/server/lib/contacts/ContactMerger.ts#L13
Unable to resolve path to module './contacts/getContactManagerIdByUsername'
|
|
🔎 Code Check / Code Lint
Process completed with exit code 1.
|
|
✅ Tests Done
Process completed with exit code 1.
|
|
Builds matrix rust bindings against alpine
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
📦 Build Packages
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3, actions/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
deploy-preview
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, actions/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
🔨 Test Unit / Unit Tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3, actions/[email protected], codecov/codecov-action@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
🔎 Code Check / TypeScript
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3, actions/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
📦 Meteor Build - coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3, actions/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
🔎 Code Check / Code Lint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3, actions/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
🔎 Code Check / Code Lint:
packages/apps-engine/src/definition/api/ApiEndpoint.ts#L33
Prefer using an optional chain expression instead, as it's more concise and easier to read
|
|
🔎 Code Check / Code Lint:
packages/apps-engine/src/server/accessors/ModifyCreator.ts#L117
Prefer using an optional chain expression instead, as it's more concise and easier to read
|
|
🔎 Code Check / Code Lint:
packages/apps-engine/src/server/accessors/ModifyCreator.ts#L158
Prefer using an optional chain expression instead, as it's more concise and easier to read
|
|
🔎 Code Check / Code Lint:
packages/apps-engine/src/server/accessors/ModifyCreator.ts#L183
Prefer using an optional chain expression instead, as it's more concise and easier to read
|
|
🔎 Code Check / Code Lint:
packages/apps-engine/src/server/accessors/ModifyCreator.ts#L201
Prefer using an optional chain expression instead, as it's more concise and easier to read
|
|
🔎 Code Check / Code Lint:
packages/apps-engine/src/server/accessors/ModifyCreator.ts#L208
Prefer using an optional chain expression instead, as it's more concise and easier to read
|
|
🔎 Code Check / Code Lint:
packages/apps-engine/src/server/accessors/ModifyCreator.ts#L213
Prefer using an optional chain expression instead, as it's more concise and easier to read
|
|
🔎 Code Check / Code Lint:
packages/apps-engine/src/server/accessors/ModifyCreator.ts#L225
Prefer using an optional chain expression instead, as it's more concise and easier to read
|
|
🔎 Code Check / Code Lint:
packages/apps-engine/src/server/accessors/ModifyCreator.ts#L229
Prefer using an optional chain expression instead, as it's more concise and easier to read
|
|
🔎 Code Check / Code Lint:
packages/apps-engine/src/server/accessors/ModifyCreator.ts#L233
Prefer using an optional chain expression instead, as it's more concise and easier to read
|
|
🚢 Build Docker Images for Testing (official)
The following actions use a deprecated Node.js version and will be forced to run on node20: docker/login-action@v2, actions/cache@v3, actions/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
🚢 Build Docker Images for Testing (debian)
The following actions use a deprecated Node.js version and will be forced to run on node20: docker/login-action@v2, actions/cache@v3, actions/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
build
|
308 MB |
|
|
turbo-build
|
15.3 MB |
|