Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Role with capability to: #81

Open
wants to merge 0 commits into
base: develop
Choose a base branch
from

Conversation

Lawri-van-Buel
Copy link

  • Configure the Databasename
  • Use access crendentials
  • Use MongoDB options, (like TLS or any other MongoDB connection option).

This should also address #40 and superseed !54

README.md Outdated
@@ -70,6 +70,11 @@ All variables have sane defaults set in [`defaults/main.yml`](defaults/main.yml)
| `rocket_chat_mongodb_port` | 27017 | The TCP port to contact the MongoDB host host via |
| `rocket_chat_mongodb_packages` | `mongodb` | The name of the MongoDB package(s) to install (differs for different distros - see `vars/`) |
| `rocket_chat_mongodb_config_template` | [`mongod.conf.j2`](templates/mongod.conf.j2) | The `/etc/mongod.conf` template to deploy |
| `rocket_chat_mongodb_database` | `rocketchat`| MongoDB Database to use. (Advanced use only). |
| `rocket_chat_mongodb_options` | `` | MongoDB (Connection) options. (Advanced use only). This is the place to set connection details like use TLS. |
| `rocket_chat_mongodb_user` | UNSET | MongoDB user (Advanced use only). Only set this is you use this! |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here and next two lines need to replace:

Only set this is you use this!

with

Only set this if you use this!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Darn Typo's. fixed all 3 of them in latest commit (3268a2b)

@Lawri-van-Buel
Copy link
Author

@xenithorb Any thoughts about merging this PR?

@xenithorb
Copy link
Collaborator

I've been a bad maintainer and forgot to merge v3.1.0 as I intended some time ago...

Most if not all of the work for that was done (differently) here: 2e078af

What I will do is review that over the weekend and incorporate any missing functionality that this PR brings. Thanks

@Lawri-van-Buel
Copy link
Author

Can you checkout PR #84 I added these changes to there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants