Update rockx-sg/ssv-spec with ssv-spec master branch

.github/workflows/lint.yaml

@@ -11,12 +11,12 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - name: Set up Go
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v5
         with:
-          go-version: 1.17
+          go-version: 1.22.x
 
       - name: Get Dependencies
         run: go get -v -t -d ./...

.github/workflows/test.yaml

@@ -11,12 +11,12 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - name: Set up Go
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v5
         with:
-          go-version: 1.17
+          go-version: 1.22.x
 
       - name: Get Dependencies
         run: go get -v -t -d ./...

.gitignore

@@ -16,6 +16,7 @@
 
 ## IDE
 .idea
+.DS_Store
 
 # binaries
 .bin

Makefile

@@ -15,8 +15,14 @@ fmt:
 
 .PHONY: test
 test:
-	@go test -v -race -timeout 20m "${TEST_PKG}"
+	@go test -v -race -timeout 25m "${TEST_PKG}"
 
 .PHONY: generate-jsons
 generate-jsons:
 	@go generate ./...
+
+.PHONY: generate-ssz
+generate-ssz:
+	@go generate ./qbft/
+	@go generate ./ssv/
+	@go generate ./types/

README.md

@@ -54,7 +54,7 @@ func ComputeSigningRoot(data MessageRoot, domain SignatureDomain) ([]byte, error
         return nil, errors.Wrap(err, "could not get root from MessageRoot")
     }
 
-    ret := sha256.Sum256(append(dataRoot, domain...))
+    ret := sha256.Sum256(append(dataRoot[:], domain...))
     return ret[:], nil
 }
 ```
@@ -184,17 +184,3 @@ To generate all json spec tests, run:
 foo@bar:~$ go generate ./...
 ```
 Then run all tests
-
-## TODO
-- [//] Proposal duty execution + spec test + consensus validator
-- [//] Aggregator duty execution + spec test + consensus validator
-- [//] Sync committee duty execution + spec test + consensus validator
-- [//] Sync committee aggregator duty
-- [ ] Duty data validation (how do we ensure malicious leader doesn't proposer a non slashable attestation/ block but with invalid data)
-- [ ] Wait 1/3 or 2/3 of slot during duty execution? how else?
-- [X] implement 7,10,13 committee sizes
-- [X] improve pre-consensus partial sigs to support signed roots which are not necessarily what the local node signed (example: node 1 signed randao/ selection proof root X but nodes 2,3,4 signed Y)
-- [X] pre and post consensus timeout redesign as 32 slot timeout can cause the next duty not to start (if it starts in less than 32 slots)
-- [ ] Move ConsensusData struct to ssv package
-- [ ] Remove? storage interface? do we use it?
-- [ ] move spec structs from go-eth2-client to protolambda/zrnt?