PUT /incarnations/{id} no longer patches incarnations #429
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PUT incarnation endpoint was not behaving as a PUT endpoint should behave. So far, it was merging the provided template data / version with what was used for the previous change - instead of requiring completely specifying the desired state of that incarnation.
This behavior for example made it impossible to delete custom values for template variables and go back to using the default value.
Changes
PUT /incarnations/{id}
no longer patches the incarnation. Instead, a change will be created that only contains the data from the requestPATCH /incarnations/{id}
endpoint was created