Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PUT /incarnations/{id} no longer patches incarnations #429

Merged
merged 5 commits into from
Nov 15, 2023

Conversation

defreng
Copy link
Contributor

@defreng defreng commented Nov 10, 2023

The PUT incarnation endpoint was not behaving as a PUT endpoint should behave. So far, it was merging the provided template data / version with what was used for the previous change - instead of requiring completely specifying the desired state of that incarnation.

This behavior for example made it impossible to delete custom values for template variables and go back to using the default value.

Changes

  • PUT /incarnations/{id} no longer patches the incarnation. Instead, a change will be created that only contains the data from the request
  • for patching (e.g. only updating the template version, without changing the template data values), a new PATCH /incarnations/{id} endpoint was created

@defreng defreng changed the title no longer accept patches on PUT incarnation endpoint PUT /incarnations/{id} no longer patches incarnations Nov 10, 2023
@defreng defreng self-assigned this Nov 10, 2023
@defreng defreng marked this pull request as ready for review November 15, 2023 12:39
@defreng defreng merged commit 4f23756 into main Nov 15, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant